Comments on: Eclipse committers, turn your NLS warnings on

By: Antoine Toulme

Antoine Toulme — Wed, 21 Jan 2009 07:16:33 +0000

OK, here it is:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=261766

By: Antoine Toulme

Antoine Toulme — Wed, 21 Jan 2009 07:09:27 +0000

Let’s open a bug against the AC, see where it goes.

By: Sean Flanigan

Sean Flanigan — Wed, 21 Jan 2009 07:05:30 +0000

Okay, that makes sense. Externalisation can be non-trivial, especially when trying to choose good keys in the resource bundles.

But I still like the idea of NON-NLS sledgehammers in RC builds.

By: Antoine Toulme

Antoine Toulme — Wed, 21 Jan 2009 05:49:56 +0000

The ugly truth, at least from my own experience, is that some manual testing is required and that requirements themselves change over time as we discover more of the solution. Also, with CVS, you have no choice but to check-in, while with Git you can commit changes locally every so often, so you keep your focus. I hate having modified files hanging around on my local copy.

So we tend to have I-builds provided to QA that aren’t externalized. Externalization is an effort that requires a lot of time from devs, and we are ready to commit to that effort when the code is mature.

It all depends on the development process of the company you work for I suppose.

By: Sean Flanigan

Sean Flanigan — Wed, 21 Jan 2009 05:09:25 +0000

True and true. Shouldn’t force the developer to externalise strings (in the code under test) before running unit tests, for instance.

However, I think it’s reasonable to expect externalised strings before checking code in. (And the wizards (or quick-fix) make it pretty easy to “ignore” non-externalised strings in test code, in bulk.)

By: Antoine Toulme

Antoine Toulme — Wed, 21 Jan 2009 04:46:26 +0000

Hey Sean, well I wanted to be nice. I think the level of error should be raised depending on the phase of development you are in.

If you need to externalize before you can run your code, you are doomed to failure. You also may want to avoid externalizing the code for the tests.

By: Sean Flanigan

Sean Flanigan — Wed, 21 Jan 2009 00:00:40 +0000

Antoine> setting the non-externalized string flag as an error when compiling
If a project is meant to be internationalised, *shouldn’t* a non-externalised string should be an error?

Chris> PDE also have a setting for this…
I didn’t know about that one, thanks Chris!

By: Chris Aniszczyk

Chris Aniszczyk — Tue, 20 Jan 2009 14:19:45 +0000

PDE also have a setting for this if you go to the Plug-in Development compiler warnings page. Catch your missing NLS entries in MANIFEST.MF and plugin.xml files.